A bit more functionality from OpenX API included #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection behaviour. Helps subsequent calls to .save! (etc) to not raise HTTP Exceptions
…patched to support it)
…id' errors from the OpenX server
…stics method to daily_statistics to stick to the OpenX API naming conventions. Kept statistics method as an alias for daily_statistics.
…ing that parameter. Added daily_statistics and banner_statistics for Publisher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your gem. As I needed a bit more functionality, I forked it, added it, used that successfully since for over a year. I also noticed that many people are using my version. I think it would be worth to merge it with your one back. Just recently someone pointed out to me that I should send you pull request and I just realised, that I haven't yet.
Cheers